Review Request: Make the 'Now listening..' presence string configurable

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104314/#review11959
-----------------------------------------------------------


Almost there!


config/telepathy-kded-config.cpp
<http://git.reviewboard.kde.org/r/104314/#comment9459>

    You don't need this check as the replace() will do nothing if there is no such string (micro-optimizaion).



config/telepathy-kded-config.cpp
<http://git.reviewboard.kde.org/r/104314/#comment9460>

    Same as above



telepathy-mpris.cpp
<http://git.reviewboard.kde.org/r/104314/#comment9461>

    This is not right. Also if there will be even slight difference with the string, it will break horribly. You should use args instead, eg. i18nc("Comment","Now listening to %1 by %2 from album %3", QLatin1String("%title"), QLatin1String("%artist"), QLatin1String("%album"));


- Martin Klapetek


On March 28, 2012, 7:41 p.m., Othmane Moustaouda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104314/
> -----------------------------------------------------------
> 
> (Updated March 28, 2012, 7:41 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Enabled the possibility for the user to set his custom 'Now listening' presence string
> 
> 
> This addresses bug 282944.
>     http://bugs.kde.org/show_bug.cgi?id=282944
> 
> 
> Diffs
> -----
> 
>   config/CMakeLists.txt bd0b3f8dd89352d3b1f5e438f56123c508574ab4 
>   config/nowplaying-lineedit.h PRE-CREATION 
>   config/nowplaying-lineedit.cpp PRE-CREATION 
>   config/nowplaying-listwidget.h PRE-CREATION 
>   config/nowplaying-listwidget.cpp PRE-CREATION 
>   config/telepathy-kded-config.h 670c513df6b0cf7e69529f980a7f809b3f3d45a0 
>   config/telepathy-kded-config.cpp 1fb515f56500407b7b221d1d5310237f8d94ca7f 
>   config/telepathy-kded-config.ui 0d616c5503b22f37c0ae4d5a94411d0f97b25d38 
>   telepathy-mpris.h d909863e68d0fdc7a6eb4ebb972d975ba224b6ef 
>   telepathy-mpris.cpp 8dae701a203f6c5ba43a622ce7125615b4392b63 
> 
> Diff: http://git.reviewboard.kde.org/r/104314/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Now playing changes
>   http://git.reviewboard.kde.org/r/104314/s/497/
> 
> 
> Thanks,
> 
> Othmane Moustaouda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120328/d06bb4f4/attachment.html>