Review Request: Change ktp-presence-applet add contact button code

Mikhail Krishtop mikhailkrishtop at gmail.com
Tue Mar 27 21:49:11 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104430/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Adding "Add new contacts" button to ktp-presence-applet. Add contact button use ktp-common-internals/Widgets add-contact-dialog.

Delete "m_" prefix from "m_addContactAction".
Account model creates before dialog opens.
Account model seems to need ContactFactory "<< Tp::Connection::FeatureRoster" property. So I remove all other from previous version.

NOTE: this commit works only with add-contact-dialog already in ktp-common-internals/Widgets. For previous patch go to kde bugtracker.  


This addresses bug 292882.
    http://bugs.kde.org/show_bug.cgi?id=292882


Diffs
-----

  CMakeLists.txt 48c679624e61548735c584e31f41f307a6327f3a 
  src/presenceapplet.h 9c0533fcd6ff1a048ac49211370b23556d469a3d 
  src/presenceapplet.cpp 53e23b171052acc3f5fa1e5b8d42b101d1d817b1 

Diff: http://git.reviewboard.kde.org/r/104430/diff/


Testing
-------


Screenshots
-----------


  http://git.reviewboard.kde.org/r/104430/s/498/


Thanks,

Mikhail Krishtop

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120327/90c3aa77/attachment.html>


More information about the KDE-Telepathy mailing list