Review Request: Make it possible to restore presence on login

[Dominik Cermak]

> On March 22, 2012, 2:25 p.m., David Edmundson wrote:
> > Code looks fine: but;
> > 
> > 1)when you create an account in the accounts KCM, we should check this flag and set the autoConnect appropriately. Otherwise new accounts are not affected, and out of sync.
> > 
> > 2) eventually it needs to happen on a per account basis and that's where things get /cRaZy/
> 
> David Edmundson wrote:
>     Edit. This isn't true is it - you have the kded module that will set it each time.
>     
>     Ignore the above.
>     
>

The kded sets it on each login for each account.

About per account basis: as for now we don't have a per account presence it doesn't make much sense to have a per account restoration.
If we have per account presences somewhere in the future it needs to be adapted for per account settings.

But for now (0.4) I think this should do it.


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104363/#review11746
-----------------------------------------------------------


On March 22, 2012, 2:17 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104363/
> -----------------------------------------------------------
> 
> (Updated March 22, 2012, 2:17 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> It's a simple approach to have this feature implemented.
> It uses the ConnectsAutomatically property and the AutomaticPresence.
> In the kcm you can enable/disable this feature (ConnectsAutomatically is set) and on every presence change the new presence is set as the AutomaticPresence.
> This way mission-control cares for setting the saved presence as soon as possible.
> 
> Note: Disabling it takes only effect after the second login, I suspect something with the change notification between kcm and kded isn't working (that signal kcm should send and kded receive). So kded sets the property only after starting...
> 
> 
> This addresses bug 281929.
>     http://bugs.kde.org/show_bug.cgi?id=281929
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c55fa8431464b62a5426a6cf29319c3f6f5fce6f 
>   autoconnect.h PRE-CREATION 
>   autoconnect.cpp PRE-CREATION 
>   config/telepathy-kded-config.cpp 1fb515f56500407b7b221d1d5310237f8d94ca7f 
>   config/telepathy-kded-config.ui 0d616c5503b22f37c0ae4d5a94411d0f97b25d38 
>   telepathy-module.h 05d8c3847587049dcc4c9329a3b4d0b0bfee7d49 
>   telepathy-module.cpp 955ceec3a8fdaacaf24463ac4e721d0a53086d30 
> 
> Diff: http://git.reviewboard.kde.org/r/104363/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120322/14413b9c/attachment.html>