Review Request: Make it possible to restore presence on login

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104363/#review11746
-----------------------------------------------------------


Code looks fine: but;

1)when you create an account in the accounts KCM, we should check this flag and set the autoConnect appropriately. Otherwise new accounts are not affected, and out of sync.

2) eventually it needs to happen on a per account basis and that's where things get /cRaZy/

- David Edmundson


On March 22, 2012, 2:17 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104363/
> -----------------------------------------------------------
> 
> (Updated March 22, 2012, 2:17 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> It's a simple approach to have this feature implemented.
> It uses the ConnectsAutomatically property and the AutomaticPresence.
> In the kcm you can enable/disable this feature (ConnectsAutomatically is set) and on every presence change the new presence is set as the AutomaticPresence.
> This way mission-control cares for setting the saved presence as soon as possible.
> 
> Note: Disabling it takes only effect after the second login, I suspect something with the change notification between kcm and kded isn't working (that signal kcm should send and kded receive). So kded sets the property only after starting...
> 
> 
> This addresses bug 281929.
>     http://bugs.kde.org/show_bug.cgi?id=281929
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c55fa8431464b62a5426a6cf29319c3f6f5fce6f 
>   autoconnect.h PRE-CREATION 
>   autoconnect.cpp PRE-CREATION 
>   config/telepathy-kded-config.cpp 1fb515f56500407b7b221d1d5310237f8d94ca7f 
>   config/telepathy-kded-config.ui 0d616c5503b22f37c0ae4d5a94411d0f97b25d38 
>   telepathy-module.h 05d8c3847587049dcc4c9329a3b4d0b0bfee7d49 
>   telepathy-module.cpp 955ceec3a8fdaacaf24463ac4e721d0a53086d30 
> 
> Diff: http://git.reviewboard.kde.org/r/104363/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120322/35f66fb1/attachment.html>