Review Request: Fix typo in Q_FLAGS + Expose presence icon.

David Edmundson kde at davidedmundson.co.uk
Thu Mar 22 04:03:32 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104360/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Fix typo in Q_FLAGS

THE RAGE REVIEW.
This bug took me all of Tuesday night to work out.
Without it the flags can't work in QML, as the correct one isn't exposed.

Lesson for everyone:
Q_FLAGS doesn't actually check you've given it a valid flag.


Also added an presenceIcon role to the model (for the contact list applet). I don't really want to add more roles, but there was no other way sensible I could think to get the icon in QML. (this is two commits in my code, just post-review being stupid uploaded them both)


Diffs
-----

  KTp/Models/accounts-filter-model.h 36f8288b0edcbd4f809b860cf54ab19dfe5ffddf 
  KTp/Models/accounts-model.h c86d8cfafad1e956f98f9111b54e8cb923926c98 
  KTp/Models/accounts-model.cpp 13aaa4cb1e9f9a49ee40191163809795a96fc611 
  KTp/Models/contact-model-item.cpp 50145688be749d0bbb83d814ce99f4f02ec387a8 

Diff: http://git.reviewboard.kde.org/r/104360/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120322/e4f2f2b6/attachment.html>


More information about the KDE-Telepathy mailing list