Review Request: More fixes for Adium Styles

[Rohan Garg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104356/#review11695
-----------------------------------------------------------



app/chat-window.h
<http://git.reviewboard.kde.org/r/104356/#comment9290>

    Gobbling up features this patch is



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104356/#comment9291>

    Fixed this stuff must be



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104356/#comment9292>

    likewise



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104356/#comment9293>

    Here



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104356/#comment9294>

    and here



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104356/#comment9295>

    here



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104356/#comment9296>

    :'(


- Rohan Garg


On March 21, 2012, 3:03 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104356/
> -----------------------------------------------------------
> 
> (Updated March 21, 2012, 3:03 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> More fixes for the adium styles. I got some help by checking adium source. ;)
> This fixes a few themes including simkete (default theme for group chats)
> 
> Branch here: http://quickgit.kde.org/index.php?p=clones%2Fktp-text-ui%2Fddomenichelli%2Fktp-text-ui.git&a=shortlog&h=refs/heads/adiumThemeFixes
> 
> 
> This addresses bug 296343.
>     http://bugs.kde.org/show_bug.cgi?id=296343
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 4afa8a1b8d6ee92f75197bf57895f3a57526c516 
>   app/chat-window.cpp 5a803e6cc7abf78aecc3929541a5830b4445d771 
>   config/kcm_ktp_chat_appearance.desktop fbefaf5043b76c86c5f7dbd9c0cb711e1118126e 
>   config/kcm_ktp_chat_behavior.desktop 6c468b7187439d21e6c0596cfe5c2e03ff30bdc9 
>   data/CMakeLists.txt 6187d40882775ae445984c7fb4c549d5016b90db 
>   data/Template.html PRE-CREATION 
>   data/styles/SimKete.AdiumMessageStyle/Contents/Info.plist PRE-CREATION 
>   data/styles/SimKete.AdiumMessageStyle/Contents/README PRE-CREATION 
>   data/styles/SimKete.AdiumMessageStyle/Contents/Resources/Incoming/Content.html PRE-CREATION 
>   data/styles/SimKete.AdiumMessageStyle/Contents/Resources/Incoming/NextContent.html PRE-CREATION 
>   data/styles/SimKete.AdiumMessageStyle/Contents/Resources/Incoming/SenderColors.txt PRE-CREATION 
>   data/styles/SimKete.AdiumMessageStyle/Contents/Resources/Outgoing/Content.html PRE-CREATION 
>   data/styles/SimKete.AdiumMessageStyle/Contents/Resources/Outgoing/NextContent.html PRE-CREATION 
>   data/styles/SimKete.AdiumMessageStyle/Contents/Resources/Status.html PRE-CREATION 
>   data/styles/SimKete.AdiumMessageStyle/Contents/Resources/main.css PRE-CREATION 
>   data/styles/simkete/Contents/Info.plist 010d8c89946197c981580b6ee22a23e2040ddc94 
>   data/styles/simkete/Contents/README dbf2563dcf8cecad57c4f2a159f1eba18a811bdc 
>   data/styles/simkete/Contents/Resources/Incoming/Content.html 5e293e9e5172f761262c7bb9f92314296db48dba 
>   data/styles/simkete/Contents/Resources/Incoming/NextContent.html 116e89f4acd98eb9ca1ece5535ce138777960ca7 
>   data/styles/simkete/Contents/Resources/Incoming/SenderColors.txt 3ec68ef04bfe887bddbda0b3a835db1042cd89c0 
>   data/styles/simkete/Contents/Resources/Outgoing/Content.html e46f049507162d41a8909e6dcdbdd31e76810ef9 
>   data/styles/simkete/Contents/Resources/Outgoing/NextContent.html de7d5c0327c339fa53727239f4b63a27a86f5752 
>   data/styles/simkete/Contents/Resources/Status.html 516af9198a360a25a5bda4f104a771e1278d0b0d 
>   data/styles/simkete/Contents/Resources/main.css 3b9f059075ef0ae545db600a8f86b3686b740388 
>   data/template.html 79224b8de5b41c36c7815ce70faa86e07ce96d01 
>   lib/adium-theme-view.h 885be8da9da1674ade29f725fbf8db48c9ae174c 
>   lib/adium-theme-view.cpp 126b221430b294481fa7581c253cf0480b31bc8b 
>   lib/chat-style-plist-file-reader.h 593e889edc7a7bff1bd6757441a065d83d06d06b 
>   lib/chat-style-plist-file-reader.cpp 5168823d88d72dc36bce5aecb04b00701832e755 
>   lib/chat-widget.h fda3106affd7e7e937671522da0ff256753866fb 
>   lib/chat-widget.cpp 907dc34c9a520f954bae3cc9c81b0a5c2e2233fc 
>   lib/chat-window-style.h 99057302a551b2dd9ea475e6506adc80ea39ccb8 
>   lib/chat-window-style.cpp 8940fa29edd776057611b3420abf97bff719a2de 
>   plasmoid/org.kde.ktp-chatplasmoid/metadata.desktop e8badfd8028e38902cdb55a589b7d5f4860d5d8d 
> 
> Diff: http://git.reviewboard.kde.org/r/104356/diff/
> 
> 
> Testing
> -------
> 
> Tested with ~60 different themes. Not all of them work, but there are a few improvements
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120321/c08c064b/attachment-0001.html>