Review Request: Set ChannelChatState as Paused when the user has not typed for the past 5 seconds

Commit Hook null at kde.org
Wed Mar 21 14:34:13 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104354/#review11690
-----------------------------------------------------------


This review has been submitted with commit ceca8bc2dc4c56b382749a5a42fbdf060fbfcd1a by Rohan Garg to branch master.

- Commit Hook


On March 21, 2012, 2:28 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104354/
> -----------------------------------------------------------
> 
> (Updated March 21, 2012, 2:28 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> When the user is done typing, a QTimer is re/started and the Paused state is set after 5 seconds.
> 
> 
> This addresses bug 296439.
>     http://bugs.kde.org/show_bug.cgi?id=296439
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.h 3d72798 
>   lib/chat-widget.cpp e852972 
> 
> Diff: http://git.reviewboard.kde.org/r/104354/diff/
> 
> 
> Testing
> -------
> 
> Works for me, except for when typing a message FROM a jabber.org account, when for some reason it sets remote contact's state as 'Composing' causing it to look like the remote party is composing. Works when you compose a message in GTalk and try to send it to a jabber.org account
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120321/9a7e1785/attachment.html>


More information about the KDE-Telepathy mailing list