Review Request: Make ktp-text-ui display " $USER entered text "
Rohan Garg
rohangarg at kubuntu.org
Tue Mar 20 14:42:44 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104348/
-----------------------------------------------------------
(Updated March 20, 2012, 2:42 p.m.)
Review request for Telepathy.
Changes
-------
Fix all previous issues by using a TpChannelChatState enum in the dpointer
Description
-------
Works exactly like GTalk now, when there is no message, only the user name is displayed, if the user is typing a message, "Typing ... John Doe" is displayed, if the user entered some text but did not hit enter "John Doe has entered text" is displayed.
This addresses bug 289861.
http://bugs.kde.org/show_bug.cgi?id=289861
Diffs (updated)
-----
app/chat-window.h 4afa8a1
app/chat-window.cpp 5a803e6
lib/chat-widget.h fda3106
lib/chat-widget.cpp 907dc34
Diff: http://git.reviewboard.kde.org/r/104348/diff/
Testing (updated)
-------
See attached screenshot
PS: It would be awesome if someone could test this in group chat.
Screenshots
-----------
http://git.reviewboard.kde.org/r/104348/s/480/
Thanks,
Rohan Garg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120320/17956d58/attachment.html>
More information about the KDE-Telepathy
mailing list