Review Request: Make the 'Now listening..' presence string configurable

[David Edmundson]

> On March 18, 2012, 1:35 a.m., Daniele Elmo Domenichelli wrote:
> > telepathy-mpris.cpp, lines 115-116
> > <http://git.reviewboard.kde.org/r/104314/diff/1/?file=53621#file53621line115>
> >
> >     You might want to allow more fields here (track number, year, gender...) see http://www.mpris.org/2.1/spec/TrackList_Node.html#Mapping:Metadata_Map and http://xmms2.org/wiki/MPRIS_Metadata for the properties that you can set
> 
> Othmane Moustaouda wrote:
>     Since the number of fields is enough consistent maybe it's better if I use a QStringList that contains all tags? Also i18n replacements managed via QStringList should be simpler...
> 
> Martin Klapetek wrote:
>     I'm a little bit against this as listing ALL possible strings might be a bit scary for average-Joe-users (just imagine when suddenly he sees a long list with string starting with %, adding some verbose explanation on how it works is also not cool to have in UI), which I tried to avoid in the first place and therefore never got to implement the editable form. Ideally I'd like the user to be able to just drag stuff (read icons/boxes/tags/somethingrectangularwithproperstringinit) in the correct position rather than having to type the stuff himself. 
>     
>     So you'd have a textarea with something like "I'm now listening to [Title (x)] by [Artist (x)] from album [Album (x)]." However it's not exactly trivial (Vishesh has something similar, we could steal it) and I'm happy with this working version as a start. So let's just leave three strings to choose from for now.
>     
>     Overall - nicely done!

Compromise - add track number as well but that's it. That's quite standard and common.

I agree we don't need /all of them/ I doubt my friends care on the of the track i'm listening to or how long the track is.
Definitely don't add the "gender" that DrDanz suggested... (unless guess he means "genre" :P )

It doesn't have to be in the default text, just in our replace code and tooltip.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104314/#review11513
-----------------------------------------------------------


On March 17, 2012, 2:29 p.m., Othmane Moustaouda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104314/
> -----------------------------------------------------------
> 
> (Updated March 17, 2012, 2:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Enabled the possibility for the user to set his custom 'Now listening' presence string
> 
> 
> This addresses bug 282944.
>     http://bugs.kde.org/show_bug.cgi?id=282944
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp 1fb515f56500407b7b221d1d5310237f8d94ca7f 
>   telepathy-mpris.h d909863e68d0fdc7a6eb4ebb972d975ba224b6ef 
>   telepathy-mpris.cpp 8dae701a203f6c5ba43a622ce7125615b4392b63 
> 
> Diff: http://git.reviewboard.kde.org/r/104314/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Othmane Moustaouda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120318/48000aa2/attachment.html>