Review Request: Make the 'Now listening..' presence string configurable

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104314/#review11513
-----------------------------------------------------------


Thanks for the patch, and welcome! A couple of comments:


telepathy-mpris.cpp
<http://git.reviewboard.kde.org/r/104314/#comment9153>

    On the other hand we might want to do this i18n replacement only when the string is set and store the string always in this form, so that if one changes the language of the application it doesn't break...
    
    I'd consider making 3 replacements:
     - the first one from i18n("%title") to QLatin1String("%title") when we save the string from the KCM module
     - the second one from QLatin1String("%title") to the real title when nowPlaying replaces it (i.e. leave it unchanged here and modify the string where it is stored from the kcm module)
     - the third one from QLatin1String("%title") to i18n("%title") when you load the entry to display it in the KCM module.
    
    In this way we always store the english version but we display the i18n one.
    
    What do you think?



telepathy-mpris.cpp
<http://git.reviewboard.kde.org/r/104314/#comment9154>

    You might want to allow more fields here (track number, year, gender...) see http://www.mpris.org/2.1/spec/TrackList_Node.html#Mapping:Metadata_Map and http://xmms2.org/wiki/MPRIS_Metadata for the properties that you can set


A big usability problem in with this patch is that you should add a tooltip and a "what's this" to the LineEdit displaying the possible fields that the user can set

- Daniele Elmo Domenichelli


On March 17, 2012, 2:29 p.m., Othmane Moustaouda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104314/
> -----------------------------------------------------------
> 
> (Updated March 17, 2012, 2:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Enabled the possibility for the user to set his custom 'Now listening' presence string
> 
> 
> This addresses bug 282944.
>     http://bugs.kde.org/show_bug.cgi?id=282944
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp 1fb515f56500407b7b221d1d5310237f8d94ca7f 
>   telepathy-mpris.h d909863e68d0fdc7a6eb4ebb972d975ba224b6ef 
>   telepathy-mpris.cpp 8dae701a203f6c5ba43a622ce7125615b4392b63 
> 
> Diff: http://git.reviewboard.kde.org/r/104314/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Othmane Moustaouda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120318/d0c4986a/attachment.html>