Review Request: Maintain a list of recently used rooms in JoinChatroomDialog

[Dominik Cermak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104269/
-----------------------------------------------------------

(Updated March 14, 2012, 11:49 a.m.)


Review request for Telepathy.


Changes
-------

Use QHash instead of QMap.
Moved bracket.
Check for empty QStringList.


Description
-------

Upon joining a room (more exact upon clicking "Ok") the room is saved in the recently used list for this account.
ATM it remembers up to 8 rooms and single rooms can be removed as well as the whole list can be cleared.

The complete list is showed in a new tab and the rooms are used for completion in the lineEdit.


This addresses bug 291711.
    http://bugs.kde.org/show_bug.cgi?id=291711


Diffs (updated)
-----

  contact-list-widget.h 154fc8fd19b6713fdccd453d100863cb4ae4fe9d 
  contact-list-widget.cpp 514a5d9cbba1918c23ac02fc6898c2354507dfc0 
  dialogs/join-chat-room-dialog.h 686fe312dc243e49feafa793106f782abb9f9f9b 
  dialogs/join-chat-room-dialog.cpp 026c5e4f3d1e068739c40a4b014daf84e8a77f8b 
  dialogs/join-chat-room-dialog.ui 839d644399b5c9031a4c4840c6e8573309c4b859 
  rooms-model.h 4040d341d2eb2536add914647bdf1209d88d6dc4 
  rooms-model.cpp 1edba641692ae0af6f1e4daaa79734b5b07a8ece 

Diff: http://git.reviewboard.kde.org/r/104269/diff/


Testing
-------


Screenshots
-----------

recent tab
  http://git.reviewboard.kde.org/r/104269/s/462/
recent completion
  http://git.reviewboard.kde.org/r/104269/s/463/


Thanks,

Dominik Cermak

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120314/6978aefe/attachment.html>