Review Request: Maintain a list of recently used rooms in JoinChatroomDialog

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104269/#review11395
-----------------------------------------------------------


Just a cursory glance.


dialogs/join-chat-room-dialog.h
<http://git.reviewboard.kde.org/r/104269/#comment9112>

    Why not use a hash? It's not like you require the string lists to be sorted.



dialogs/join-chat-room-dialog.cpp
<http://git.reviewboard.kde.org/r/104269/#comment9111>

     I know this was like this before, but why have the closing parenthesis on the next line?



dialogs/join-chat-room-dialog.cpp
<http://git.reviewboard.kde.org/r/104269/#comment9114>

    This could potentially insert an <key, QStringList()> in the map.
    
    Maybe you should check is the string list if empty. Unless, that's what you wanted.


- Vishesh Handa


On March 14, 2012, 11 a.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104269/
> -----------------------------------------------------------
> 
> (Updated March 14, 2012, 11 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Upon joining a room (more exact upon clicking "Ok") the room is saved in the recently used list for this account.
> ATM it remembers up to 8 rooms and single rooms can be removed as well as the whole list can be cleared.
> 
> The complete list is showed in a new tab and the rooms are used for completion in the lineEdit.
> 
> 
> This addresses bug 291711.
>     http://bugs.kde.org/show_bug.cgi?id=291711
> 
> 
> Diffs
> -----
> 
>   dialogs/join-chat-room-dialog.h 686fe312dc243e49feafa793106f782abb9f9f9b 
>   dialogs/join-chat-room-dialog.cpp 026c5e4f3d1e068739c40a4b014daf84e8a77f8b 
>   dialogs/join-chat-room-dialog.ui 839d644399b5c9031a4c4840c6e8573309c4b859 
> 
> Diff: http://git.reviewboard.kde.org/r/104269/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> recent tab
>   http://git.reviewboard.kde.org/r/104269/s/462/
> recent completion
>   http://git.reviewboard.kde.org/r/104269/s/463/
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120314/e27a623d/attachment.html>