Review Request: Add SSH Contact filtering

[Daniele Elmo Domenichelli]

> On March 13, 2012, 11:51 p.m., David Edmundson wrote:
> > KTp/Models/contact-model-item.cpp, line 225
> > <http://git.reviewboard.kde.org/r/104265/diff/1/?file=53055#file53055line225>
> >
> >     Why can't you do it the same way we do audio/video?
> >     
> >     if me->capabilities().streamTubes(QLatin1String("x-ssh-contact")); 
> >     
> >

Because that me->capabilities() returns if you have the capability to handle the channel with requested=false
Since our handler for audio/video is the same for requested=true and requested=false that is not a problem, but conceptually it's wrong and might break if the user changes the handler to something that supports only one direction (quite unlikely though).
But if you check, for krfb a few lines before we are doing the same using KTp::ServiceAvailabilityChecker

We should solve both problems using the desktop files and perhaps subclassing the filter class instead of adding stuff here


> On March 13, 2012, 11:51 p.m., David Edmundson wrote:
> > KTp/Models/accounts-model.h, line 94
> > <http://git.reviewboard.kde.org/r/104265/diff/1/?file=53052#file53052line94>
> >
> >     Long term we can't make a new role for every new stream tube.
> >     
> >     It doesn't make sense to recompile the common library each time someone adds Telepathy support to an app.

I agree, this is a temporary workaroud to the problem and I wasn't sure when I wrote the class if adding the share destop stuff.


- Daniele Elmo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104265/#review11378
-----------------------------------------------------------


On March 13, 2012, 11:46 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104265/
> -----------------------------------------------------------
> 
> (Updated March 13, 2012, 11:46 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add "SSH Contact" filtering to the models
> 
> 
> Diffs
> -----
> 
>   KTp/Models/accounts-filter-model.h c23b2843b6ff5a431c4cca275005c1cb4a9ad498 
>   KTp/Models/accounts-filter-model.cpp 5beb201c1a91ef3347f338d7b5301df372833dc5 
>   KTp/Models/accounts-model.h a67912d9d4a727da3556a628295cf2e50f49da1e 
>   KTp/Models/accounts-model.cpp 51fca8802d1522f0b3ed57414c749e8ae0255ece 
>   KTp/Models/contact-model-item.h 4d8ce512de9541c1013aa5cd38859a9bfd45f1f6 
>   KTp/Models/contact-model-item.cpp 50145688be749d0bbb83d814ce99f4f02ec387a8 
> 
> Diff: http://git.reviewboard.kde.org/r/104265/diff/
> 
> 
> Testing
> -------
> 
> Works, but at the moment I don't know how to check if ssh-contact is installed
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120314/df162af8/attachment.html>