Review Request: Add a special button to edit presence message, return presence combo back to regular behaviour

[Dominik Cermak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104168/#review11173
-----------------------------------------------------------

Ship it!



global-presence-chooser.cpp
<http://git.reviewboard.kde.org/r/104168/#comment9005>

    As now it's not only about the spinner maybe rename it to repositionOverlays() or something similar.



global-presence-chooser.cpp
<http://git.reviewboard.kde.org/r/104168/#comment9006>

    Not part of your changes but while you are at it could you please correct it to "the same file" ;-)


- Dominik Cermak


On March 6, 2012, 9:51 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104168/
> -----------------------------------------------------------
> 
> (Updated March 6, 2012, 9:51 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This reverts the click-to-set-message behavior of the presence chooser combobox and adds a button to change the message. I wanted to add a 'Confirm' button once in the edit mode, but I just couldn't position it on top of the lineedit, so I left saving only on enter key press for now. See screenshot (that has mouse over effect over the button, otherwise the button is flat, ie. has no edges).
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.h e57cfdc 
>   global-presence-chooser.cpp d935f76 
> 
> Diff: http://git.reviewboard.kde.org/r/104168/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/104168/s/447/
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120306/68210587/attachment.html>