Review Request: Return KTp::Presence from CurrentPresenceRole and AutomaticPresenceRole

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104160/#review11143
-----------------------------------------------------------

Ship it!


We really need to make a list of all the roles we actually use. (it'll make it easier to sort out the new models.)

Anyway, change is fine :)

- David Edmundson


On March 5, 2012, 4:20 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104160/
> -----------------------------------------------------------
> 
> (Updated March 5, 2012, 4:20 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Return KTp::Presence from CurrentPresenceRole and AutomaticPresenceRole
> 
> Add CurrentPresenceStatusRole and AutomaticPresenceStatusRole to
> replace the previous version of CurrentPresenceRole and
> AutomaticPresenceRole.
> 
> I didn't find any place where those are used, so this shouldn't cause any problem (except that you will need to rebuild the places where KTp::AccountsModel is used)
> 
> Also rename role strings to match the role names (I'm not sure if this will break some plasmoid)
> 
> 
> Diffs
> -----
> 
>   KTp/Models/accounts-model.h cca956a3dcaacbf3a05c81dd150e4fe036bbe6d6 
>   KTp/Models/accounts-model.cpp 748bcedc01fd5d6a3538358ead88b52e3573aa03 
>   KTp/Models/accounts-model-item.cpp feef5d92e7714952d2416bbb7b432e1568ca1f32 
> 
> Diff: http://git.reviewboard.kde.org/r/104160/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120305/99c09b4c/attachment.html>