Review Request: Only show valid options in contact context menu

[David Edmundson]

> On June 25, 2012, 10:35 a.m., Alex Fiestas wrote:
> > Can't tell what this patch does exactly (screenshots !) but generally across all KDE software people usually grey out entries instead of removing them. 
> > Maybe until there is a new standard ktp should do the same?
> 
> Martin Klapetek wrote:
>     It dynamically adds/removes entries in the context menu based on the available support for these actions. 
>     
>     On this I have to agree with Alex. Disabling the menu items improves feature discoverability and it's used in other KDE apps. Can you just disable it?

ok for "block" I'll change to enable/disable so that keeps consistent when you click on the contacts.

I really don't think the "Re-request/Resend Authorisation" should be always there. They're only useful in a very small set of cases, and one of the main purposes of this patch was to reduce the size of the context menu. The user can expect a different menu because this contact is visibly in a different state (with the yellow warning icon instead of a presence). There's plenty of examples where menus do change, like on different filetypes in dolphin for example.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105344/#review15107
-----------------------------------------------------------


On June 24, 2012, 11:14 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105344/
> -----------------------------------------------------------
> 
> (Updated June 24, 2012, 11:14 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Check if contact manager supports blocking contact before adding the item.
> Also only show re-request/resend authentication if it actually is a valid option.
> 
> 
> Diffs
> -----
> 
>   context-menu.cpp 988f321 
>   dialogs/remove-contact-dialog.cpp 7b5fa1f 
> 
> Diff: http://git.reviewboard.kde.org/r/105344/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120625/626fb68f/attachment.html>