Review Request: Image Plugin

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105313/#review15088
-----------------------------------------------------------


This review has been submitted with commit 1563f416d25fd6f8b235a6bf6d03da953b610592 by Lasath Fernando to branch master.

- Commit Hook


On June 25, 2012, 1:02 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105313/
> -----------------------------------------------------------
> 
> (Updated June 25, 2012, 1:02 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is a plugin to Embed Images directly into a chat. (I pretty much rewrote the old code from scratch because I realized I wasn't very happy with it).
> 
> I've also bumped the version number of all the plugins. 
> 
> This diff depends on diff of the previous review (which I still haven't merged yet). I'll merge them both once this gets reviewed. 
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt PRE-CREATION 
>   filters/emoticons/ktptextui_message_filter_emoticons.desktop PRE-CREATION 
>   filters/escape/CMakeLists.txt PRE-CREATION 
>   filters/escape/escape-filter.h PRE-CREATION 
>   filters/escape/escape-filter.cpp PRE-CREATION 
>   filters/escape/ktptextui_message_filter_escape.desktop PRE-CREATION 
>   filters/formatting/format-filter.cpp PRE-CREATION 
>   filters/formatting/ktptextui_message_filter_formatting.desktop PRE-CREATION 
>   filters/images/CMakeLists.txt PRE-CREATION 
>   filters/images/images-filter.h PRE-CREATION 
>   filters/images/images-filter.cpp PRE-CREATION 
>   filters/images/ktptextui_message_filter_images.desktop PRE-CREATION 
>   lib/CMakeLists.txt e94a432 
>   lib/filters.h 2aed5bd 
>   lib/message-processor.h d6228b5 
>   lib/message-processor.cpp a9b409e 
>   tests/message-processor-basic-tests.h PRE-CREATION 
>   tests/message-processor-basic-tests.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105313/diff/
> 
> 
> Testing
> -------
> 
> Passed Unit tests, saw memes in chat. 
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120625/8bcf6b0e/attachment-0001.html>