Review Request: Image Plugin

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105313/#review15084
-----------------------------------------------------------



filters/images/images-filter.cpp
<http://git.reviewboard.kde.org/r/105313/#comment11854>

    Why QLatin1Literal instead of QLatin1String?



filters/images/images-filter.cpp
<http://git.reviewboard.kde.org/r/105313/#comment11853>

    Still not i18n
    



lib/message-processor.cpp
<http://git.reviewboard.kde.org/r/105313/#comment11855>

    It would probably be more readable to move this up a line and change it to "append".
    
    Add the EscapeFilter here too in the same way and convert it from being a dynamically loaded plugin to just a regular class (like UrlFilter)
    (as discussed on IRC this morning)


- David Edmundson


On June 23, 2012, 5:25 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105313/
> -----------------------------------------------------------
> 
> (Updated June 23, 2012, 5:25 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is a plugin to Embed Images directly into a chat. (I pretty much rewrote the old code from scratch because I realized I wasn't very happy with it).
> 
> I've also bumped the version number of all the plugins. 
> 
> This diff depends on diff of the previous review (which I still haven't merged yet). I'll merge them both once this gets reviewed. 
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt PRE-CREATION 
>   filters/emoticons/ktptextui_message_filter_emoticons.desktop PRE-CREATION 
>   filters/escape/ktptextui_message_filter_escape.desktop PRE-CREATION 
>   filters/formatting/format-filter.cpp PRE-CREATION 
>   filters/formatting/ktptextui_message_filter_formatting.desktop PRE-CREATION 
>   filters/images/CMakeLists.txt PRE-CREATION 
>   filters/images/images-filter.h PRE-CREATION 
>   filters/images/images-filter.cpp PRE-CREATION 
>   filters/images/ktptextui_message_filter_images.desktop PRE-CREATION 
>   lib/message-processor.cpp a9b409e 
>   tests/message-processor-basic-tests.h PRE-CREATION 
>   tests/message-processor-basic-tests.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105313/diff/
> 
> 
> Testing
> -------
> 
> Passed Unit tests, saw memes in chat. 
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120625/e63cb1ea/attachment.html>