Review Request: Fix the 1px branch line on the left of the view (in contacts).

Martin Klapetek martin.klapetek at gmail.com
Sun Jun 24 19:45:02 UTC 2012



> On June 24, 2012, 7:30 p.m., David Edmundson wrote:
> > Good that we're paying attention to these 1px issues! It's the attention to details that make a project awesome.
> > Well done.

Please add a comment to the .cpp file explaining why you're doing that, thanks :)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105342/#review15079
-----------------------------------------------------------


On June 24, 2012, 6:03 p.m., Nikita Skovoroda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105342/
> -----------------------------------------------------------
> 
> (Updated June 24, 2012, 6:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> There is a 0px identation, so no branches are shown. If that's on purpose, then the branches should be disabled completely.
> If not, there is a 1px branch line on the left of all items in the contact-list view.
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.h 911c0f2 
>   contact-list-widget.cpp 30c84ba 
> 
> Diff: http://git.reviewboard.kde.org/r/105342/diff/
> 
> 
> Testing
> -------
> 
> Nothing was broken.
> 1px line disappared.
> 
> 
> Thanks,
> 
> Nikita Skovoroda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120624/51792094/attachment.html>


More information about the KDE-Telepathy mailing list