Review Request: Fix logic in onRequestedPresenceChanged()

David Edmundson kde at davidedmundson.co.uk
Sat Jun 2 11:27:33 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105133/#review14366
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On June 2, 2012, 7:38 a.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105133/
> -----------------------------------------------------------
> 
> (Updated June 2, 2012, 7:38 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix logic in onRequestedPresenceChanged()
> 
> statusMessage was missing before and it should be 'or' instead of 'and'.
> Now it's the same as in onCurrentPresenceChanged().
> This fixes presence saving in the case that only the presence message
> changed.
> 
> 
> Diffs
> -----
> 
>   KTp/global-presence.cpp 985148a09727e4bcfbd86381e13dad7ea0c0586d 
> 
> Diff: http://git.reviewboard.kde.org/r/105133/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120602/bd31eb58/attachment.html>


More information about the KDE-Telepathy mailing list