Review Request: Respect filters for counters
Dominik Cermak
d.cermak at arcor.de
Fri Jun 1 20:23:34 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105130/
-----------------------------------------------------------
(Updated June 1, 2012, 8:23 p.m.)
Review request for Telepathy.
Changes
-------
Transformed the online count to one line thanks to Martin.
Description
-------
I tried to solve it on filter model level. Here is what I've done so far, it's not finished yet but I want to show it so you can speak up if it's totally (or partly) wrong, so I don't waste time. I still have to find out what I can remove from the other code now.
Also it's not so nice to have so much in data(), so if someone has an idea how to make this more elegant, I'm open for suggestions.
This addresses bug 300956.
http://bugs.kde.org/show_bug.cgi?id=300956
Diffs (updated)
-----
KTp/Models/accounts-filter-model.h 9ed824a1e9a970e33b07343ae9143734857820c8
KTp/Models/accounts-filter-model.cpp c17b3359178ffceca5ae815d41008058218f3bf5
Diff: http://git.reviewboard.kde.org/r/105130/diff/
Testing
-------
Now the counters work as expected.
Thanks,
Dominik Cermak
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120601/42dc3371/attachment.html>
More information about the KDE-Telepathy
mailing list