Review Request: Add syntax for changing global presence

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105407/#review16727
-----------------------------------------------------------


looks good to me, some minor nitpicking


src/contactrunner.h
<http://git.reviewboard.kde.org/r/105407/#comment13015>

    I guess this is a leftover, since it's not really needed in your patch



src/contactrunner.cpp
<http://git.reviewboard.kde.org/r/105407/#comment13016>

    Using .arg for a translatable string is really bad. I'd ask for feedback about this from a translator or translation manager (I suggest Albert) to find out what's best to do.



src/contactrunner.cpp
<http://git.reviewboard.kde.org/r/105407/#comment13017>

    In general throughout all of the code, there is a mix of QLatin1String-ized strings and standard strings. I would opt for having all of the strings passed as a QLatin1String if possible.


- Dario Freddi


On July 31, 2012, 5:15 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105407/
> -----------------------------------------------------------
> 
> (Updated July 31, 2012, 5:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch adds syntax for changing global presence:
> 
> go online|away|busy|hidden|offline [status message]
> 
> The status message is optional. The "go" keyword and presence names are translatable.
> 
> 
> Diffs
> -----
> 
>   src/contactrunner.h d73abe1 
>   src/contactrunner.cpp aa03390 
> 
> Diff: http://git.reviewboard.kde.org/r/105407/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120731/568c8e5d/attachment-0001.html>