Review Request: [ktp-log-viewer] Global Search

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105586/#review16493
-----------------------------------------------------------

Ship it!


To me this looks a lot better than the last one. I hope you agree.

Few minor comments, don't need to see another patch, just fix and ship.

Finally could you update main.cpp:31 and insert the following line
    aboutData.addAuthor(ki18n("Dan Vratil"), ki18n("Developer"), "dan at progdan.cz");




logviewer/entity-proxy-model.h
<http://git.reviewboard.kde.org/r/105586/#comment12857>

    no longer needed



logviewer/entity-proxy-model.cpp
<http://git.reviewboard.kde.org/r/105586/#comment12856>

    matches_filter -> matchesFilter


- David Edmundson


On July 26, 2012, 10:21 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105586/
> -----------------------------------------------------------
> 
> (Updated July 26, 2012, 10:21 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Added a KLineEdit to the bottom part of the window. Hitting enter starts global search for given term. Only entities with at least one matching log are displayed. Only dates with matching logs are displayed. Matching terms are highlighted in the MessageView. I am cool.
> 
> 
> This addresses bug 294652.
>     http://bugs.kde.org/show_bug.cgi?id=294652
> 
> 
> Diffs
> -----
> 
>   logviewer/conversation-date-picker.h 868eb43 
>   logviewer/conversation-date-picker.cpp 3817083 
>   logviewer/entity-proxy-model.h 0548081 
>   logviewer/entity-proxy-model.cpp ac1bbf5 
>   logviewer/log-viewer.h 2b13bc1 
>   logviewer/log-viewer.cpp 04fba29 
>   logviewer/log-viewer.ui 7e4097f 
>   logviewer/message-view.h 9e01260 
>   logviewer/message-view.cpp 1f51a83 
> 
> Diff: http://git.reviewboard.kde.org/r/105586/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120726/a8fd40fa/attachment.html>