Review Request: [ktp-log-viewer] Global Search

[Dan Vratil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105586/
-----------------------------------------------------------

(Updated July 26, 2012, 10:17 p.m.)


Review request for Telepathy.


Changes
-------

Updated so that the patch does not touch the entity-model. The Tpl::SearchHitList is stored only in the filter model and datePicker. The filter model checks whether there's at least one match in the SearchHitList and either displays or hides the contact. The datePicker will get dates from all SearchHits that match current Entity or, if there are no SearchHits, will display all Entity's logs dates.

I also fixed the entity filter model so that you can still use the 'Filter contacts' field even when the model is already filtered by the global search.


Description
-------

Added a KLineEdit to the bottom part of the window. Hitting enter starts global search for given term. Only entities with at least one matching log are displayed. Only dates with matching logs are displayed. Matching terms are highlighted in the MessageView. I am cool.


This addresses bug 294652.
    http://bugs.kde.org/show_bug.cgi?id=294652


Diffs (updated)
-----

  logviewer/conversation-date-picker.h 868eb43 
  logviewer/conversation-date-picker.cpp 3817083 
  logviewer/entity-proxy-model.h 0548081 
  logviewer/entity-proxy-model.cpp ac1bbf5 
  logviewer/log-viewer.h 2b13bc1 
  logviewer/log-viewer.cpp 04fba29 
  logviewer/log-viewer.ui 7e4097f 
  logviewer/message-view.h 9e01260 
  logviewer/message-view.cpp 1f51a83 

Diff: http://git.reviewboard.kde.org/r/105586/diff/


Testing
-------


Thanks,

Dan Vratil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120726/ff31a66f/attachment.html>