Review Request: Fix on Bug 295106 (The reset button in kcm_ktp_chat_apparence is not working)

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105701/#review16282
-----------------------------------------------------------


Good work, just 2 comments.


kde-telepathy
<http://git.reviewboard.kde.org/r/105701/#comment12798>

    Assuming that ChatWindowStyleManager is a singleton, connecting it multiple times to the same slot will only cause the slot to be called multiple times, which is a bad thing. Therefore, the connect() call still needs to be in the constructor and not in defaults() and load().



kde-telepathy
<http://git.reviewboard.kde.org/r/105701/#comment12799>

    For clarity's sake, I'd rather have the "virtual" keyword in front of these three method declarations, since they are virtual in the parent class.


- George Kiagiadakis


On July 23, 2012, 10:31 p.m., Nick Lou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105701/
> -----------------------------------------------------------
> 
> (Updated July 23, 2012, 10:31 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix for the Bug 295106 (The reset button in kcm_ktp_chat_apparence is not working).
> The same problem was with the default button, fixed that too.
> 
> 
> This addresses bug 295106.
>     http://bugs.kde.org/show_bug.cgi?id=295106
> 
> 
> Diffs
> -----
> 
>   kde-telepathy 2e0ed61 
>   kde-telepathy 876d0ed 
> 
> Diff: http://git.reviewboard.kde.org/r/105701/diff/
> 
> 
> Testing
> -------
> 
> On theme config settings:
> 1)Applying a theme.
> 2)Pressing default button //action: setting options to default values.
> 3)Pressing reset button //action:setting options to applied values
> 4)Repeating this procedure several times, trying different theme combinations before and after applying changes each time.
> 
> 
> Thanks,
> 
> Nick Lou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120723/4d8f6907/attachment-0001.html>