Review Request: Fix on Bug 295106 (The reset button in kcm_ktp_chat_apparence is not working)

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105701/#review16277
-----------------------------------------------------------


Nicely done! One last issue before it can be shipped.


kde-telepathy
<http://git.reviewboard.kde.org/r/105701/#comment12795>

    Don't add useless whitespace ;)



kde-telepathy
<http://git.reviewboard.kde.org/r/105701/#comment12796>

    I know you just moved this code, but shouldn't these lines be swapped? Ie. first connect the signal and then call loadStyles()? Otherwise we might not catch that signal at all. Unless it's done on purpose...



kde-telepathy
<http://git.reviewboard.kde.org/r/105701/#comment12797>

    Same here


- Martin Klapetek


On July 23, 2012, 10:01 p.m., Nick Lou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105701/
> -----------------------------------------------------------
> 
> (Updated July 23, 2012, 10:01 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix for the Bug 295106 (The reset button in kcm_ktp_chat_apparence is not working).
> The same problem was with the default button, fixed that too.
> 
> 
> This addresses bug 295106.
>     http://bugs.kde.org/show_bug.cgi?id=295106
> 
> 
> Diffs
> -----
> 
>   kde-telepathy 2e0ed61 
>   kde-telepathy 876d0ed 
> 
> Diff: http://git.reviewboard.kde.org/r/105701/diff/
> 
> 
> Testing
> -------
> 
> On theme config settings:
> 1)Applying a theme.
> 2)Pressing default button //action: setting options to default values.
> 3)Pressing reset button //action:setting options to applied values
> 4)Repeating this procedure several times, trying different theme combinations before and after applying changes each time.
> 
> 
> Thanks,
> 
> Nick Lou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120723/17cc3729/attachment.html>