Review Request: Add syntax for changing global presence

Dan Vratil dan at progdan.cz
Sat Jul 21 23:39:09 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105407/
-----------------------------------------------------------

(Updated July 21, 2012, 11:39 p.m.)


Review request for Telepathy.


Changes
-------

Updated the runner syntax:

Two new keywords from Kopete runner to connect/disconnect:
connect
disconnect
(I made these translatable, as it seems more natural to me)

Two synonymous syntaxes to change status (first suggested by drdanz, the other one is from Kopete runner and was mentioned by Martin too):
im <status>
status <status>
(I think there's absolutely no harm in having them both; I left they keywords and the statuses non-translatable)

And some cool syntaxes to set status message:
im <status> <status message>
status <status> <status message>
(The Kopete runner uses "message" keyword to change status message, but that sounds to general (what message?!), so I rejected it)


Description
-------

This patch adds syntax for changing global presence:

go online|away|busy|hidden|offline [status message]

The status message is optional. The "go" keyword and presence names are translatable.


Diffs (updated)
-----

  src/contactrunner.h d73abe1 
  src/contactrunner.cpp aa03390 

Diff: http://git.reviewboard.kde.org/r/105407/diff/


Testing
-------


Thanks,

Dan Vratil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120721/41d88ebc/attachment.html>


More information about the KDE-Telepathy mailing list