Review Request: Minimalistic delegate (aka Lydia Pintscher mode)
David Edmundson
kde at davidedmundson.co.uk
Sun Jul 15 22:29:21 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105477/#review15930
-----------------------------------------------------------
Ship it!
Diff got a bit messed up due to a lack of rebasing, or fetching or something...but ship it anyway.
- David Edmundson
On July 15, 2012, 10:25 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105477/
> -----------------------------------------------------------
>
> (Updated July 15, 2012, 10:25 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> This implements even smaller delegate for people who like to see looooots of contacts at once. I'm just not sure about using smallestReadableFont(), see screenshot - the generalFont() (on right) is good enough imho. Also the sizeHint() still should probably take font size into account.
>
>
> This addresses bug 303051.
> http://bugs.kde.org/show_bug.cgi?id=303051
>
>
> Diffs
> -----
>
> contact-delegate-compact.h 7fa2907
> contact-delegate-compact.cpp 948e5a8
> contact-list-widget.h 724050d
> contact-list-widget.cpp ee65883
> main-widget.cpp 79869b8
>
> Diff: http://git.reviewboard.kde.org/r/105477/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Screenshots
> -----------
>
> Mini delegate, smallest font on left, general on right
> http://git.reviewboard.kde.org/r/105477/s/618/
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120715/a5549601/attachment.html>
More information about the KDE-Telepathy
mailing list