Review Request: [ktp-log-viewer] Filter EntityView by both account name and real name

Commit Hook null at kde.org
Sun Jul 15 17:11:31 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105556/#review15902
-----------------------------------------------------------


This review has been submitted with commit 3a3a945eabe205d33e6788b929ac29a8f67861fd by Dan Vrátil to branch master.

- Commit Hook


On July 15, 2012, 5:06 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105556/
> -----------------------------------------------------------
> 
> (Updated July 15, 2012, 5:06 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> The EntityView improvements I made previously only support filtering by real name (Tp::Contact::alias()), but sometimes you might want to filter contacts by their account name (Tpl::Entity::alias()) instead of real name.
> 
> When real names are not available (you are offline), view is filtered only by account names.
> 
> 
> Diffs
> -----
> 
>   logviewer/entity-proxy-model.cpp e431cd0 
> 
> Diff: http://git.reviewboard.kde.org/r/105556/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120715/e5478467/attachment.html>


More information about the KDE-Telepathy mailing list