Review Request: [ktp-log-viewer] Filter EntityView by both account name and real name

Dan Vratil dan at progdan.cz
Sun Jul 15 17:06:24 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105556/
-----------------------------------------------------------

(Updated July 15, 2012, 5:06 p.m.)


Review request for Telepathy.


Changes
-------

Better code readability and comments!


Description
-------

The EntityView improvements I made previously only support filtering by real name (Tp::Contact::alias()), but sometimes you might want to filter contacts by their account name (Tpl::Entity::alias()) instead of real name.

When real names are not available (you are offline), view is filtered only by account names.


Diffs (updated)
-----

  logviewer/entity-proxy-model.cpp e431cd0 

Diff: http://git.reviewboard.kde.org/r/105556/diff/


Testing
-------


Thanks,

Dan Vratil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120715/57d2c870/attachment.html>


More information about the KDE-Telepathy mailing list