Review Request: [ktp-log-viewer] Fix model warnings

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105579/#review15893
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On July 15, 2012, 4:32 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105579/
> -----------------------------------------------------------
> 
> (Updated July 15, 2012, 4:32 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix runtime warnings when filling EntityModel + simplify the code.
> 
> The culprit was in using completely incorrect row numbers in beginInsertRows().
> 
> 
> This addresses bug 303336.
>     http://bugs.kde.org/show_bug.cgi?id=303336
> 
> 
> Diffs
> -----
> 
>   logviewer/entity-model.cpp a7b0d95 
> 
> Diff: http://git.reviewboard.kde.org/r/105579/diff/
> 
> 
> Testing
> -------
> 
> Builds, works, no warnings
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120715/b6be6bbc/attachment.html>