Review Request: [ktp-log-viewer] Add links to navigate between previous and next conversations

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105578/#review15886
-----------------------------------------------------------

Ship it!


Nicely done.

I particularly like that it's not invasive on the main AdiumThemeView. Subclassing that was a wise move.

I'm wondering if it's worth making any of those others virtual. Better to do it now rather than when we supposedly have a stable API.

- David Edmundson


On July 15, 2012, 2:55 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105578/
> -----------------------------------------------------------
> 
> (Updated July 15, 2012, 2:55 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds links to previous and next conversations (if exist) to simply navigate between past conversations.
> 
> Question: I use the "Status" template now (AdiumThemeStatusInfo), but that contains a timestamp of the "message" which really makes no sense in this context. But I can't just update/add templates, can I?
> 
> 
> Diffs
> -----
> 
>   lib/adium-theme-view.h 8892fed 
>   logviewer/conversation-date-picker.h dd177cc 
>   logviewer/conversation-date-picker.cpp 9c76333 
>   logviewer/log-viewer.h f9f16c5 
>   logviewer/log-viewer.cpp a6ae6d0 
>   logviewer/message-view.h e4b9b88 
>   logviewer/message-view.cpp 72b58cc 
> 
> Diff: http://git.reviewboard.kde.org/r/105578/diff/
> 
> 
> Testing
> -------
> 
> Builds and works :-)
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120715/b5ad0879/attachment.html>