Review Request: Show the 'phone' client type in contact list

[Dominik Cermak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105514/
-----------------------------------------------------------

(Updated July 15, 2012, 1:28 p.m.)


Review request for Telepathy.


Changes
-------

The votes are for the first version (shots 1 and 2), so I'm going for that.
Make the eliding work a bit better.
Use QIcon instead of KIcon.


Description
-------

This shows a phone icon left of the presence icon for contacts that are online with a phone.
Currently it only shows the client type of 'phone' (other possible are: bot, console, handheld, pc, web), because I think this is the most important. Also interesting could be 'web'.

The usability group is added for comments/discussion about the place where to put the icon. What do you think about it?


This addresses bug 302963.
    http://bugs.kde.org/show_bug.cgi?id=302963


Diffs (updated)
-----

  contact-delegate-compact.cpp 91f3497bac5585d922d1d6c071e3ec6b8796daa1 
  contact-delegate.cpp 2b8a86398340d9b11e05e9928f9c64f396ce8e00 
  main-widget.cpp ac4fd415cee72bb0d450a0bb2205f58d9e94e3d7 

Diff: http://git.reviewboard.kde.org/r/105514/diff/


Testing
-------


Screenshots
-----------

Full List
  http://git.reviewboard.kde.org/r/105514/s/621/
Compact List
  http://git.reviewboard.kde.org/r/105514/s/622/
Version where the icon moved to the left
  http://git.reviewboard.kde.org/r/105514/s/623/
Presence moved to the left
  http://git.reviewboard.kde.org/r/105514/s/624/
Avatar Overlay
  http://git.reviewboard.kde.org/r/105514/s/625/
Presence overlay
  http://git.reviewboard.kde.org/r/105514/s/626/


Thanks,

Dominik Cermak

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120715/a527526f/attachment.html>