Review Request: KWallet::Wallet::openWallet or will it?

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105566/
-----------------------------------------------------------

(Updated July 14, 2012, 3:08 p.m.)


Review request for Telepathy.


Changes
-------

Updated to be a mix of the two requests.

There exists a static method to create a PendingWalletOperation which offers a pointer to the singleton WalletInterface.

Still has potential threading issues, but everything should run in the same thread anyway. It's no worse than before this patch.


Description
-------

Adds a method to asynchronously open the wallet. This must be called (and completed) by the application if they want to use any other methods.
API is a bit horrendous, but that's mostly because of KWallet.

Wallet opening appears as a Tp::PendingOperation so that it can be used in a composite job.


Diffs (updated)
-----

  KTp/CMakeLists.txt 61da66d 
  KTp/pending-wallet-operation.h PRE-CREATION 
  KTp/pending-wallet-operation.cpp PRE-CREATION 
  KTp/wallet-interface.h c43fb38 
  KTp/wallet-interface.cpp d2dc2cb 

Diff: http://git.reviewboard.kde.org/r/105566/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120714/0d09e291/attachment.html>