Review Request: Show the 'phone' client type in contact list

[Alin M Elena]

Maybe the last activity device shall be reflected... activity may mean change 
of status... or sending messages.

Alin


On Thu 12 Jul 2012 13:42:58 Dominik Cermak wrote:


This is an automatically generated e-mail. To reply, visit: 
http://git.reviewboard.kde.org/r/105514/ 


On July 12th, 2012, noon, George Kiagiadakis wrote: 

contact-delegate.cpp (Diff revision 1) 
void ContactDelegate::paintContact(QPainter *painter, const QStyleOptionViewItem &option, const QModelIndex &index) const


105
    if (index.data(AccountsModel::ClientTypesRole).toStringList().contains(QLatin1String("phone"))) {

I'm not sure this is correct.

This list will contain all the client types for the contact's current 
presence. For example, if the contact is "available" on the pc and "away" on 
the phone, this list will contain only "pc" and the presence of the contact 
will be "available". Vice versa, if the user is "available" on the phone and 
"away" on the pc, this list will contain only "phone" and the presence will 
be "available". Everything is fine up to this point. If you try to talk to 
this person, XMPP should normally choose to notify the most available 
resource of this contact, which would be the pc in the first case and the 
phone in the second case.

However, if a contact is "available" on both the pc and the phone, this list 
will contain both "pc" and "phone". Therefore, if you try to talk to this 
person, she should be notified on both devices. In this case, imho, the phone 
icon should not be there, as there is at least one other client that is not a 
phone that will be notified. 
This is not how it works, if a contact is "available" on both the pc and the 
phone the list will contain only "pc" or only "phone". Which one is shown 
depends on which changed to this status last. So if I'm "available" with my 
pc, then connect with my phone (also "available") clientTypes would contain 
only "phone" and vice versa. It works in the same way as the presence 
messages.


- Dominik 

On July 11th, 2012, 9:06 p.m., Dominik Cermak wrote: 
Review request for Telepathy and KDE Usability.
By Dominik Cermak. 
Updated July 11, 2012, 9:06 p.m. 
Description 
This shows a phone icon left of the presence icon for contacts that are online 
with a phone.
Currently it only shows the client type of 'phone' (other possible are: bot, 
console, handheld, pc, web), because I think this is the most important. Also 
interesting could be 'web'.

The usability group is added for comments/discussion about the place where to 
put the icon. What do you think about it? 

Bugs: 302963 
Diffs 
contact-delegate-compact.cpp (91f3497bac5585d922d1d6c071e3ec6b8796daa1) 
contact-delegate.cpp (2b8a86398340d9b11e05e9928f9c64f396ce8e00) 
main-widget.cpp (2baebe3dcbb173ea56586f765b459321bfdad6bd) 
View Diff 
Screenshots 
      




-- 
Without Questions there are no Answers!
______________________________________________________________________
Alin Marin ELENA
Advanced Molecular Simulation Research Laboratory
School of Physics, University College Dublin
----
Ardionsamblú Móilíneach Saotharlann Taighde
Scoil na Fisice, An Coláiste Ollscoile, Baile Átha Cliath

-----------------------------------------------------------------------------------
http://alin.elenaworld.net
______________________________________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120712/093b6474/attachment-0001.html>