Review Request: Show the 'phone' client type in contact list

[Heiko Tietze]

> On July 11, 2012, 7:42 p.m., Heiko Tietze wrote:
> > Ship It!

But reconsider the overlay. It works with your phone icon scaled to 8x12px (tested with Gimp).


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105514/#review15692
-----------------------------------------------------------


On July 11, 2012, 7:34 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105514/
> -----------------------------------------------------------
> 
> (Updated July 11, 2012, 7:34 p.m.)
> 
> 
> Review request for Telepathy and KDE Usability.
> 
> 
> Description
> -------
> 
> This shows a phone icon left of the presence icon for contacts that are online with a phone.
> Currently it only shows the client type of 'phone' (other possible are: bot, console, handheld, pc, web), because I think this is the most important. Also interesting could be 'web'.
> 
> The usability group is added for comments/discussion about the place where to put the icon. What do you think about it?
> 
> 
> This addresses bug 302963.
>     http://bugs.kde.org/show_bug.cgi?id=302963
> 
> 
> Diffs
> -----
> 
>   contact-delegate-compact.cpp 91f3497bac5585d922d1d6c071e3ec6b8796daa1 
>   contact-delegate.cpp 2b8a86398340d9b11e05e9928f9c64f396ce8e00 
>   main-widget.cpp 2baebe3dcbb173ea56586f765b459321bfdad6bd 
> 
> Diff: http://git.reviewboard.kde.org/r/105514/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Full List
>   http://git.reviewboard.kde.org/r/105514/s/621/
> Compact List
>   http://git.reviewboard.kde.org/r/105514/s/622/
> Version where the icon moved to the left
>   http://git.reviewboard.kde.org/r/105514/s/623/
> Presence moved to the left
>   http://git.reviewboard.kde.org/r/105514/s/624/
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120711/86bfc542/attachment-0001.html>