Review Request: Support drag and drop file transfer from text-ui

Dan Vratil dan at progdan.cz
Wed Jul 11 10:47:11 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105511/
-----------------------------------------------------------

(Updated July 11, 2012, 10:47 a.m.)


Review request for Telepathy.


Changes
-------

Fixed the event handling implementation, added Q_ASSERTs to all casts, renamed the methods and variable and became more realistic about what mime types we can handle - reduced to URLs, text/plain, text/html and images only.


Description
-------

- dropping a local URL starts a file transfer
- dropping a remote URL appends it to the SendMessageBox
- dropping text or HTML data appends it to the SendMessageBox
- dropping image data creates a temporary file (PNG), starts a file transfer and when it's finished the file is removed again


This addresses bug 288561.
    http://bugs.kde.org/show_bug.cgi?id=288561


Diffs (updated)
-----

  app/main.cpp b8b2523 
  lib/chat-widget.h 686b632 
  lib/chat-widget.cpp e3439d8 

Diff: http://git.reviewboard.kde.org/r/105511/diff/


Testing
-------


Thanks,

Dan Vratil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120711/66a025b7/attachment.html>


More information about the KDE-Telepathy mailing list