Review Request: Add ClientTypesRole

David Edmundson kde at davidedmundson.co.uk
Wed Jul 11 10:13:42 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105513/#review15663
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On July 11, 2012, 10:03 a.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105513/
> -----------------------------------------------------------
> 
> (Updated July 11, 2012, 10:03 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This adds the ClientTypesRole and requires TelepathyQt >= 0.9.2.1.
> This is needed for the following patch for contact-list.
> 
> As this changes the enum, should I bump the sonumber?
> 
> 
> This addresses bug 302963.
>     http://bugs.kde.org/show_bug.cgi?id=302963
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 491780fcf3bd0bd9a764cbd2f151c5c4aa19fcf1 
>   KTp/Models/accounts-model.h 23f901d57c012dd1ed3ef12c5d15859aaeed1728 
>   KTp/Models/contact-model-item.cpp 02615507f7a11e956692bcd1785f2042ff59e9d1 
> 
> Diff: http://git.reviewboard.kde.org/r/105513/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120711/1219e996/attachment.html>


More information about the KDE-Telepathy mailing list