Review Request: Support drag and drop file transfer from text-ui

[David Edmundson]

> On July 10, 2012, 10:44 p.m., David Edmundson wrote:
> > lib/chat-widget.cpp, line 353
> > <http://git.reviewboard.kde.org/r/105511/diff/1/?file=72045#file72045line353>
> >
> >     WHOA!!!!!!!!!!!!!!!!!!!
> >     
> >     I'm pretty sure you just deleted any file we sent regardless of whether it was temp or not!
> >     
> >     So if I dragged a local file from my home directory to when the transfer ends you delete it!
> >     
> >
> 
> Dan Vratil wrote:
>     No, this signal is emitted only for the temporary image files.

I withdraw my "whoa!!!111" 
If this is only for when upload of temp files state changes, method should be fileTransferTempFileStateChanged or some such.

Alternately we could pass a hint to the file transfer handler to say "isTemporary", "true" and then the FT can delete it itself afterwards
(akin to using Kate's command line arg --temporary for doing this sort of thing)

Advantages:  Simpler code in all apps that launch this (which is hopefully more than just this one soon), still deletes if you close the text-ui whilst transferring.
Disadvantages: Assumes our handler will be used.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105511/#review15645
-----------------------------------------------------------


On July 10, 2012, 9:32 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105511/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 9:32 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> - dropping a local URL starts a file transfer
> - dropping a remote URL appends it to the SendMessageBox
> - dropping text or HTML data appends it to the SendMessageBox
> - dropping image data creates a temporary file (PNG), starts a file transfer and when it's finished the file is removed again
> 
> 
> This addresses bug 288561.
>     http://bugs.kde.org/show_bug.cgi?id=288561
> 
> 
> Diffs
> -----
> 
>   app/main.cpp b8b2523 
>   lib/chat-text-edit.h 3e2dec0 
>   lib/chat-text-edit.cpp 2985aee 
>   lib/chat-widget.h 686b632 
>   lib/chat-widget.cpp e3439d8 
> 
> Diff: http://git.reviewboard.kde.org/r/105511/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120710/dd300b1e/attachment-0001.html>