Review Request: Initialize AdiumThemeHeaderInfoPrivate::isGroupChat

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Tue Jul 10 22:36:31 UTC 2012



> On July 10, 2012, 10:34 p.m., Daniele Elmo Domenichelli wrote:
> > Ship It!

Even though a proper fix should actually check if the chat is a group chat... But for now I believe it is ok.


- Daniele Elmo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105512/#review15646
-----------------------------------------------------------


On July 10, 2012, 10:29 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105512/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 10:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Always initialize AdiumThemeHeaderInfoPrivate::isGroupChat to false. This fixes the bug when group-chat header template was randomly used in LogViewer.
> 
> 
> This addresses bug 296271.
>     http://bugs.kde.org/show_bug.cgi?id=296271
> 
> 
> Diffs
> -----
> 
>   lib/adium-theme-header-info.cpp 8a8aded 
> 
> Diff: http://git.reviewboard.kde.org/r/105512/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120710/19505856/attachment-0001.html>


More information about the KDE-Telepathy mailing list