Review Request: Minimalistic delegate (aka Lydia Pintscher mode)

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105477/#review15545
-----------------------------------------------------------



contact-delegate-compact.h
<http://git.reviewboard.kde.org/r/105477/#comment12148>

    "magic booleans" suck.
    use an enum.
    
    if you see ContactDelgateCompact(true) you have no idea (without reading docs) what it means.
    
    ContactDeelgateCompact(Mini) is far easier to read.
    
    There's a blog post everyone always links to when saying this... can't remember where/what.



contact-delegate-compact.cpp
<http://git.reviewboard.kde.org/r/105477/#comment12150>

    this needs to be a qmax(avatarSize+ spacing, fontsize)
    
    if your mini font is quite large (which is quite plausible) this won't fit



contact-delegate-compact.cpp
<http://git.reviewboard.kde.org/r/105477/#comment12151>

    I think setting it to the size of the font here makes a lot of sense. To keep things as small as possible.
    
    Less so for the non-mini mode.


- David Edmundson


On July 8, 2012, 2:51 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105477/
> -----------------------------------------------------------
> 
> (Updated July 8, 2012, 2:51 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This implements even smaller delegate for people who like to see looooots of contacts at once. I'm just not sure about using smallestReadableFont(), see screenshot - the generalFont() (on right) is good enough imho. Also the sizeHint() still should probably take font size into account.
> 
> 
> This addresses bug 303051.
>     http://bugs.kde.org/show_bug.cgi?id=303051
> 
> 
> Diffs
> -----
> 
>   contact-delegate-compact.h 7fa2907 
>   contact-delegate-compact.cpp 91f3497 
>   contact-list-widget.h 724050d 
>   contact-list-widget.cpp ee65883 
>   main-widget.cpp 2baebe3 
> 
> Diff: http://git.reviewboard.kde.org/r/105477/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Screenshots
> -----------
> 
> Mini delegate, smallest font on left, general on right
>   http://git.reviewboard.kde.org/r/105477/s/618/
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120708/f0cd8a1a/attachment.html>