Review Request: Few improvements in LogViewer

Dan Vratil dan at progdan.cz
Thu Jul 5 20:52:10 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105450/
-----------------------------------------------------------

(Updated July 5, 2012, 8:52 p.m.)


Review request for Telepathy.


Changes
-------

Fixed crash when clearing empty view.


Description
-------

- display entities as a per-account tree view
- try to display contact's real name (or nickname) if possible. This does not work when account is offline (we need active connection), in such case it falls back to TelepathyLoggerQt4::Entity::alias()
- use QSplitter to make width of the EntityView and MessageView adjustable
- make the window slightly bigger by default


Diffs (updated)
-----

  logviewer/CMakeLists.txt bb22191 
  logviewer/entity-model-item.h PRE-CREATION 
  logviewer/entity-model-item.cpp PRE-CREATION 
  logviewer/entity-model.h cd6649e 
  logviewer/entity-model.cpp a661d10 
  logviewer/entity-proxy-model.h PRE-CREATION 
  logviewer/entity-proxy-model.cpp PRE-CREATION 
  logviewer/entity-view.h 03c23d1 
  logviewer/entity-view.cpp 1ef5ef4 
  logviewer/log-viewer.h 04820fd 
  logviewer/log-viewer.cpp 2b472fa 
  logviewer/log-viewer.ui c5e6a09 

Diff: http://git.reviewboard.kde.org/r/105450/diff/


Testing
-------


Thanks,

Dan Vratil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120705/14322621/attachment.html>


More information about the KDE-Telepathy mailing list