Review Request: Add syntax for changing global presence

[David Edmundson]

> On July 4, 2012, 3:07 p.m., David Edmundson wrote:
> > src/contactrunner.cpp, line 124
> > <http://git.reviewboard.kde.org/r/105407/diff/1/?file=70950#file70950line124>
> >
> >     The reason we have setAccountManager is so that you can create the globalPresence object at initialisation. 
> >     
> >     Move the "m_globalPresence = new KTp::GlobalPresence()" to the ctor.
> >     
> >     Same for AccountsModel.
> >     Then you can remove your destructor, and remove your checks everywhere.
> 
> Dan Vratil wrote:
>     m_globalPresence nor m_accountsModel are shared pointers, so they must be delete()'d anyway, right?

No, normal QObjects, set a parent and they'll be deleted magically.
(in fact currently they're sort of deleted twice which is awkward.. but broken)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105407/#review15378
-----------------------------------------------------------


On July 2, 2012, 8:22 a.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105407/
> -----------------------------------------------------------
> 
> (Updated July 2, 2012, 8:22 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch adds syntax for changing global presence:
> 
> go online|away|busy|hidden|offline [status message]
> 
> The status message is optional. The "go" keyword and presence names are translatable.
> 
> 
> Diffs
> -----
> 
>   src/contactrunner.h c316aa4 
>   src/contactrunner.cpp 0d48c79 
> 
> Diff: http://git.reviewboard.kde.org/r/105407/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120705/364eee80/attachment.html>