Review Request: Add support for ktp-log-viewer

[Dominik Cermak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105441/#review15379
-----------------------------------------------------------

Ship it!


One last thing from me, although I'm not sure if it's an issue, see below.
If this is fixed/no issue then ship it!


src/contactrunner.cpp
<http://git.reviewboard.kde.org/r/105441/#comment11985>

    And I also missed something:
    Shouldn't it be 'term.mid(4).trimmed()'?
    I don't know but looking at the other actions I think it should.


- Dominik Cermak


On July 4, 2012, 2:44 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105441/
> -----------------------------------------------------------
> 
> (Updated July 4, 2012, 2:44 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch adds support for opening ktp-log-viewer for specific contact via KRunner using "log" keyword (I was thinking about using "history" keyword, but KTp doesn't seem to use it anywhere). Also, the "Open log viewer" action is available for every contact that supports text chats.
> 
> 
> Diffs
> -----
> 
>   src/contactrunner.h c316aa4 
>   src/contactrunner.cpp 0d48c79 
> 
> Diff: http://git.reviewboard.kde.org/r/105441/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120704/5ad8667d/attachment.html>