Review Request: Add support for ktp-log-viewer

Dominik Cermak d.cermak at arcor.de
Wed Jul 4 14:35:11 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105441/#review15375
-----------------------------------------------------------


One little thing, else it's fine for me.


src/contactrunner.cpp
<http://git.reviewboard.kde.org/r/105441/#comment11976>

    Here it says 'history' in line 202 it looks for 'log'.


- Dominik Cermak


On July 4, 2012, 2:26 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105441/
> -----------------------------------------------------------
> 
> (Updated July 4, 2012, 2:26 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch adds support for opening ktp-log-viewer for specific contact via KRunner using "log" keyword (I was thinking about using "history" keyword, but KTp doesn't seem to use it anywhere). Also, the "Open log viewer" action is available for every contact that supports text chats.
> 
> 
> Diffs
> -----
> 
>   src/contactrunner.h c316aa4 
>   src/contactrunner.cpp 0d48c79 
> 
> Diff: http://git.reviewboard.kde.org/r/105441/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120704/ca551862/attachment-0001.html>


More information about the KDE-Telepathy mailing list