Review Request: Add support for ktp-log-viewer

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105441/#review15373
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/105441/#comment11971>

    I don't agree with this. Runtime dependencies shouldn't be checked at compile time, they should be checked at runtime!
    
    You could use KStandardDirs::findExe() (or whatever it is called, I don't remember) to find the ktp-log-viewer at runtime and if it's not found, disable the actions.


- George Kiagiadakis


On July 4, 2012, 1:59 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105441/
> -----------------------------------------------------------
> 
> (Updated July 4, 2012, 1:59 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch adds support for opening ktp-log-viewer for specific contact via KRunner using "log" keyword (I was thinking about using "history" keyword, but KTp doesn't seem to use it anywhere). Also, the "Open log viewer" action is available for every contact that supports text chats.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1fc0e3b 
>   cmake/modules/FindGIO.cmake PRE-CREATION 
>   cmake/modules/FindQtGLib.cmake PRE-CREATION 
>   cmake/modules/FindTelepathyGlib.cmake PRE-CREATION 
>   cmake/modules/FindTelepathyLogger.cmake PRE-CREATION 
>   cmake/modules/FindTelepathyLoggerQt4.cmake PRE-CREATION 
>   src/contactrunner.cpp 0d48c79 
> 
> Diff: http://git.reviewboard.kde.org/r/105441/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120704/3eb5a9bc/attachment.html>