Review Request: Start of a log viewer

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103820/#review10219
-----------------------------------------------------------



logviewer/entity-model.cpp
<http://git.reviewboard.kde.org/r/103820/#comment8406>

    Not really relevant to your review: why does Tpl implement its own PendingOperation?



logviewer/entity-model.cpp
<http://git.reviewboard.kde.org/r/103820/#comment8407>

    is this a file or raw data? If it's raw data, the pixmap isn't cached and this call will be slow and resource-intensive more than it should if called more than once



logviewer/entity-model.cpp
<http://git.reviewboard.kde.org/r/103820/#comment8405>

    misses an &



logviewer/log-viewer.h
<http://git.reviewboard.kde.org/r/103820/#comment8408>

    Missing copyright (in other files as well)



logviewer/log-viewer.cpp
<http://git.reviewboard.kde.org/r/103820/#comment8409>

    If you are not using glib directly, at least the two glib ones shouldn't be. Can't tell about tpl::init(), but looks like we need to have a closer look at that library anyway.



logviewer/message-view.cpp
<http://git.reviewboard.kde.org/r/103820/#comment8410>

    Why are you using a static cast here? Ideally we prefer QObject or dynamic on pointers


- Dario Freddi


On Jan. 29, 2012, 1:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103820/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2012, 1:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Initial start of a log viewer.
> 
> It's not finished, there are lots of TODOs but the current stuff works. I want to get this merged with current features then do the rest as small patches.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d1cc185 
>   lib/CMakeLists.txt 5d39a62 
>   logviewer/CMakeLists.txt PRE-CREATION 
>   logviewer/entity-model.h PRE-CREATION 
>   logviewer/entity-model.cpp PRE-CREATION 
>   logviewer/log-viewer.h PRE-CREATION 
>   logviewer/log-viewer.cpp PRE-CREATION 
>   logviewer/log-viewer.ui PRE-CREATION 
>   logviewer/main.cpp PRE-CREATION 
>   logviewer/message-view.h PRE-CREATION 
>   logviewer/message-view.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103820/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120130/997bcf0b/attachment.html>