Review Request: Start of a log viewer

[Dominik Cermak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103820/#review10212
-----------------------------------------------------------

Ship it!


Can't tell about the CMake stuff but the rest is ok for me.


logviewer/entity-model.h
<http://git.reviewboard.kde.org/r/103820/#comment8401>

    Not needed if it's empty.



logviewer/entity-model.cpp
<http://git.reviewboard.kde.org/r/103820/#comment8402>

    Move the "else" on line to the top after the bracket.


- Dominik Cermak


On Jan. 29, 2012, 1:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103820/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2012, 1:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Initial start of a log viewer.
> 
> It's not finished, there are lots of TODOs but the current stuff works. I want to get this merged with current features then do the rest as small patches.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d1cc185 
>   lib/CMakeLists.txt 5d39a62 
>   logviewer/CMakeLists.txt PRE-CREATION 
>   logviewer/entity-model.h PRE-CREATION 
>   logviewer/entity-model.cpp PRE-CREATION 
>   logviewer/log-viewer.h PRE-CREATION 
>   logviewer/log-viewer.cpp PRE-CREATION 
>   logviewer/log-viewer.ui PRE-CREATION 
>   logviewer/main.cpp PRE-CREATION 
>   logviewer/message-view.h PRE-CREATION 
>   logviewer/message-view.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103820/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120129/28c2dc08/attachment.html>