Review Request: Enhance icon behaviour of text ui

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103811/#review10175
-----------------------------------------------------------


1) Main icon is always the same (telepathy-kde) and adds an overlay when a new messages is received

The main window icon of text ui should imho be the presence icon. Two reasons: 1) Contact list has the same icon; this would become unclear on icon-only task managers or even the default one, when you have so many windows opened that you can barely see the text. You wouldn't know which window is which. 2) It's nice that you can see the presence right in the taskbar. Use-case: I want to write message to David, I look down at my tasbakr, I see he's busy/away so I won't disturb him now. When he comes online, I can see this right away by the icon change in the taskbar.

In the light of the above - this point is 'no' from me.

2) Tab bar is always shown

Not sure you actually need this. The typing notification is always shown in window title, so {c|s}ould the "you've got new message" icon. If you have only one chat opened, it takes vertical space for nothing and we shouldn't waste it (especially netbook users etc wouldn't like it).

So this point is not as big 'no' as the first one, but still rather 'no'-ish.

3) The user icon has an overlay if the user is typing or if there is an unread message (unread takes precedence over typing because I tried with 2 overlays and it looks horrible)
4) Give the precedence to new messages over typing for name colour

So if I got this right - I get new message and the user is typing, I won't see him typing? That's not too nice. Use-case: The user sends me a message to a window I have on a second screen, but not focused (can be on the same screen obviously). The message ending is ambiguous and I'm not sure if that was really the message ending or if he's writing a follow-up message. Quickly looking at the icon/tab color would give me a clue right away, but with your proposed solution, I would see only the new message icon and I would have to give focus to the window to dismiss the new message icon and see if the user is typing.

To sum it up - Improvements: yes. This proposal: sorry.

- Martin Klapetek


On Jan. 28, 2012, 2:30 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103811/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2012, 2:30 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> We spoke about this some time ago on irc...
> Currently the behaviour of the main icon is not really useful.
> With this patch the icon will change when you receive a message, and it will make it easier to understand that you have an unread message (at the moment if you don't notice the blinking app in the task manager it's not easy to spot)
> 
> This set of patches do the following (you may agree or disagree with some of them, I'm not really convinced by all of them, so let's discuss it)
> 
> 1) Main icon is always the same (telepathy-kde) and adds an overlay when a new messages is received
> 2) Tab bar is always shown
> 3) The user icon has an overlay if the user is typing or if there is an unread message (unread takes precedence over typing because I tried with 2 overlays and it looks horrible)
> 4) Give the precedence to new messages over typing for name colour
> 
> branch is here: http://quickgit.kde.org/index.php?p=clones%2Fktp-text-ui%2Fddomenichelli%2Fktp-text-ui.git&a=shortlog&h=refs/heads/iconEnhancement
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 4afa8a1b8d6ee92f75197bf57895f3a57526c516 
>   app/chat-window.cpp 59db66db442dffbb3352ca1c66133f1c461d1b59 
>   lib/chat-widget.cpp 872de0299cd0eb11d61f9bab6ba12fe493336207 
> 
> Diff: http://git.reviewboard.kde.org/r/103811/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120128/d5b5975e/attachment.html>