Review Request: Use KTp::ServiceAvailabilityChecker to check if krfb is available

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103810/#review10171
-----------------------------------------------------------



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/103810/#comment8362>

    It should be in the library, together with all the other preferred handlers (see a couple of lines before this), and I think that this is something we have to do for 0.4 (perhaps making them configurable), but I believe it belongs to a later patch...
    
    But I just realized that the same string was defined as "PREFERRED_RFB_HANDLER"... should I use that instead?


- Daniele Elmo Domenichelli


On Jan. 28, 2012, 1:17 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103810/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2012, 1:17 p.m.)
> 
> 
> Review request for Telepathy, George Kiagiadakis and David Edmundson.
> 
> 
> Description
> -------
> 
> Use KTp::ServiceAvailabilityChecker to check if krfb is available
> 
> see also ktp-common-internals/KTp/Models/contact-model-item.cpp
> 
> 
> Diffs
> -----
> 
>   app/CMakeLists.txt 88a6571dba35eb5ac2339a7c1cb51d6b288972ed 
>   app/chat-window.cpp 59db66db442dffbb3352ca1c66133f1c461d1b59 
> 
> Diff: http://git.reviewboard.kde.org/r/103810/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120128/f063445a/attachment.html>